Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component wrapper on step nav component #4482

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Dec 6, 2024

What

  • Adds the component wrapper helper to the step by step navigation component.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4482 December 6, 2024 15:07 Inactive
@AshGDS AshGDS force-pushed the step-nav-component-wrapper branch from 02f3b4c to fb9781b Compare December 6, 2024 15:14
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4482 December 6, 2024 15:14 Inactive
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner 👍

@AshGDS AshGDS force-pushed the step-nav-component-wrapper branch from fb9781b to 2b78a68 Compare December 17, 2024 12:28
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4482 December 17, 2024 12:29 Inactive
@AshGDS AshGDS merged commit 833a3dc into main Dec 17, 2024
12 checks passed
@AshGDS AshGDS deleted the step-nav-component-wrapper branch December 17, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants